Added functions to initialize buttons with pin pulled down (supporting "active-high" topologies)#1
Open
Taugeshtu wants to merge 1 commit into
Open
Added functions to initialize buttons with pin pulled down (supporting "active-high" topologies)#1Taugeshtu wants to merge 1 commit into
Taugeshtu wants to merge 1 commit into
Conversation
… up ("active-high" topology)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I know it's out of nowhere, but I'm using this library in my project, and I needed support for active-high buttons (buttons that pull to VCC rather than ground). Figured I'd submit a PR in case you're interested in integrating that into the main branch of the library.
The change is entirely opt-in, so updating the library with it should not break existing projects.
If that's not aligned with your priorities - feel free to just close the PR without any further action.