Native autograd interface#249
Open
yebai wants to merge 2 commits into
Open
Conversation
Closed
Member
Author
|
@gdalle, given your limited familiarity with the Turing.jl codebase, it may be best to add your comments only where explicitly invited. |
|
I did not comment on the Turing-specific parts, but I thought you might want to benefit from my familiarity with DifferentiationInterface and all of its backends, and from Billy's familiarity with Enzyme. Voluntary reviews are usually welcome in open-source projects |
Member
Author
|
Your enthusiasm and engagement are noted and appreciated. I don't think we will benefit more from comments on DI at this stage -- your comments created a lot of attention/pressure on whether DI should be a hard dependency of Turing.jl, which is beyond feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.