Implement AbstractMCMC.{to,from}_samples (again)#1112
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
==========================================
+ Coverage 81.23% 81.50% +0.26%
==========================================
Files 40 40
Lines 3805 3844 +39
==========================================
+ Hits 3091 3133 +42
+ Misses 714 711 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Benchmark Report for Commit 6117826Computer InformationBenchmark Results |
Contributor
|
DynamicPPL.jl documentation for PR #1112 is available at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially the same PR as #1087, copy pasted but just with a different name (
AbstractMCMC.to_samplesinstead ofDynamicPPL.from_chains, andAbstractMCMC.from_samplesinstead ofDynamicPPL.to_chains).This follows on from TuringLang/AbstractMCMC.jl#184.
Since #1087 was already reviewed and discussed quite extensively, and this is completely the same code, I will probably merge this once CI passes.