Enable opting out of TSVI#1128
Closed
penelopeysm wants to merge 50 commits into
Closed
Conversation
Closed
Contributor
Benchmark Report for Commit 6a0ecfaComputer InformationBenchmark Results |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## breaking #1128 +/- ##
============================================
+ Coverage 81.32% 81.69% +0.36%
============================================
Files 40 42 +2
Lines 3807 3922 +115
============================================
+ Hits 3096 3204 +108
- Misses 711 718 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
penelopeysm
commented
Nov 8, 2025
Contributor
|
DynamicPPL.jl documentation for PR #1128 is available at: |
62c6351 to
9a74692
Compare
699aa23 to
c35dff5
Compare
* Make InitContext work with OnlyAccsVarInfo * Do not convert NamedTuple to Dict * remove logging * Enable InitFromPrior and InitFromUniform too * Fix `infer_nested_eltype` invocation
9a74692 to
e5a038e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance gains in #1132 are only really significant when not using TSVI.
TSVI gets used more than it should (#1086).
This PR provides a mechanism to globally opt out of TSVI, in a way that is fully backwards-compatible.
Changing this to a global opt-in would just require changing the default to
false.A per-model opt-in would be doable too, albeit requiring more work. I think it's better to start from a global one and only consider a per-model one if people complain.
Performance
Edit: benchmarking this, I just realised that dereferencing
USE_THREADSAFE_EVALgives rise to more overhead than checking Threads.nthreads(). A per-model one should make this work better because if it's stored in the type, it can be removed at compile time. I'll investigate this further.