Add more LDF accessor functions that Turing requires#1366
Merged
Conversation
Contributor
Benchmark Report
Computer InformationBenchmark Results |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1366 +/- ##
=======================================
Coverage 82.35% 82.35%
=======================================
Files 49 49
Lines 3502 3502
=======================================
Hits 2884 2884
Misses 618 618 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
DynamicPPL.jl documentation for PR #1366 is available at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on TuringLang/Turing.jl#2790 made me realise that LDF simply doesn't make enough of its internals explicit. Turing thus faces a choice of either depending on DPPL internals or using hacky workarounds. This PR therefore exposes a lower-level constructor for LogDensityFunction that allows Turing to essentially update the model in an LDF without having to rely on private fields (bad) or recreate any of the other arguments (hacky). See TuringLang/Turing.jl#2790 (comment).