Skip to content

don't print messages in run_ad when verbose=false#1372

Merged
penelopeysm merged 2 commits into
mainfrom
py/shush
Apr 26, 2026
Merged

don't print messages in run_ad when verbose=false#1372
penelopeysm merged 2 commits into
mainfrom
py/shush

Conversation

@penelopeysm
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 26, 2026

Benchmark Report

  • this PR's head: fb74f797d233e226baacbdc9122ee8e6182badf3
  • base branch: de25f13a4c566da8414afc3991433fb939291cee

Computer Information

Julia Version 1.11.9
Commit 53a02c0720c (2026-02-06 00:27 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

┌───────────────────────┬───────┬─────────────┬────────┬───────────────────────────────┬────────────────────────────┬─────────────────────────────────┐
│                       │       │             │        │       t(eval) / t(ref)        │     t(grad) / t(eval)      │        t(grad) / t(ref)         │
│                       │       │             │        │ ─────────┬──────────┬──────── │ ───────┬─────────┬──────── │ ──────────┬───────────┬──────── │
│                 Model │   Dim │  AD Backend │ Linked │     base │  this PR │ speedup │   base │ this PR │ speedup │      base │   this PR │ speedup │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│               Dynamic │    10 │    mooncake │   true │   281.89 │   275.78 │    1.02 │   7.62 │    8.51 │    0.90 │   2148.28 │   2346.34 │    0.92 │
│                   LDA │    12 │ reversediff │   true │  2521.72 │  2554.73 │    0.99 │   2.10 │    2.18 │    0.96 │   5295.61 │   5579.49 │    0.95 │
│   Loop univariate 10k │ 10000 │    mooncake │   true │ 30413.73 │ 30410.87 │    1.00 │   6.66 │    6.60 │    1.01 │ 202413.45 │ 200832.94 │    1.01 │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│    Loop univariate 1k │  1000 │    mooncake │   true │  3094.92 │  3096.54 │    1.00 │   6.51 │    6.42 │    1.01 │  20141.31 │  19890.20 │    1.01 │
│      Multivariate 10k │ 10000 │    mooncake │   true │ 31838.93 │ 31840.83 │    1.00 │  15.44 │    9.85 │    1.57 │ 491641.10 │ 313717.13 │    1.57 │
│       Multivariate 1k │  1000 │    mooncake │   true │  3384.36 │  3427.27 │    0.99 │   9.47 │   11.04 │    0.86 │  32043.62 │  37827.39 │    0.85 │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│ Simple assume observe │     1 │ forwarddiff │  false │     0.88 │     0.88 │    1.00 │  10.40 │   10.36 │    1.00 │      9.14 │      9.08 │    1.01 │
│           Smorgasbord │   201 │ forwarddiff │  false │   943.61 │  1481.72 │    0.64 │  72.24 │   90.03 │    0.80 │  68163.31 │ 133402.24 │    0.51 │
│           Smorgasbord │   201 │      enzyme │   true │  1286.14 │  1287.62 │    1.00 │   4.86 │    4.94 │    0.98 │   6249.73 │   6354.71 │    0.98 │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│           Smorgasbord │   201 │ forwarddiff │   true │  1283.65 │  1331.49 │    0.96 │  67.57 │   66.73 │    1.01 │  86736.94 │  88851.92 │    0.98 │
│           Smorgasbord │   201 │    mooncake │   true │  1284.15 │  1282.59 │    1.00 │   4.82 │    4.71 │    1.02 │   6191.34 │   6046.38 │    1.02 │
│           Smorgasbord │   201 │ reversediff │   true │  1270.15 │  1333.73 │    0.95 │ 130.71 │  121.46 │    1.08 │ 166015.02 │ 161992.30 │    1.02 │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│              Submodel │     1 │    mooncake │   true │     0.88 │     0.88 │    1.00 │  26.31 │   27.64 │    0.95 │     23.10 │     24.22 │    0.95 │
└───────────────────────┴───────┴─────────────┴────────┴──────────┴──────────┴─────────┴────────┴─────────┴─────────┴───────────┴───────────┴─────────┘

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.30%. Comparing base (de25f13) to head (fb74f79).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/test_utils/ad.jl 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1372      +/-   ##
==========================================
- Coverage   82.35%   82.30%   -0.05%     
==========================================
  Files          49       49              
  Lines        3502     3504       +2     
==========================================
  Hits         2884     2884              
- Misses        618      620       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@penelopeysm penelopeysm merged commit 4201c6c into main Apr 26, 2026
21 of 23 checks passed
@penelopeysm penelopeysm deleted the py/shush branch April 26, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant