Move FlexiChains ext to here#1379
Conversation
Benchmark Report
Computer InformationBenchmark Results |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1379 +/- ##
==========================================
- Coverage 82.26% 79.08% -3.18%
==========================================
Files 49 51 +2
Lines 3512 3692 +180
==========================================
+ Hits 2889 2920 +31
- Misses 623 772 +149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
DynamicPPL.jl documentation for PR #1379 is available at: |
|
@penelopeysm, is there a reason why you prefer this to be in DynamicPPL? |
|
Yes -- in fact I would prefer to keep it in FlexiChains. However, unfortunately, if FC has an extension (and thus a compat bound) on DPPL, DPPL will never be able to release a breaking version because there will be no version of FC that will work with it. This is the same problem as in #740. |
|
(This is kinda what I meant when I said that it's a faff to make FlexiChains a hard dep of Turing -- I have to move the DPPL ext and Turing exts here.) |
|
Hmmmmmmm, thinking about it, I might be wrong here. The DynamicPPL ext can still live there, but the Turing ext has to be moved to Turing. That would probably make life easier. It does mean that the testing can only happen on the FlexiChains side, which one might consider a bit dangerous. But that's what happens now anyway, so it's no major loss compared to the current situation. |
This will almost certainly cause problems immediately because FlexiChains still has a DynamicPPL extension. I'll do a simultaneous release on FlexiChains to get rid of the duplicated code.