Skip to content

Fix duplicate benchmark comments#1391

Merged
yebai merged 1 commit into
mainfrom
issue-1389
May 8, 2026
Merged

Fix duplicate benchmark comments#1391
yebai merged 1 commit into
mainfrom
issue-1389

Conversation

@shravanngoswamii
Copy link
Copy Markdown
Member

@shravanngoswamii shravanngoswamii commented May 8, 2026

Removing this in PR #1386 caused it

Closes #1389

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

DynamicPPL.jl documentation for PR #1391 is available at:
https://TuringLang.github.io/DynamicPPL.jl/previews/PR1391/

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.56%. Comparing base (8f52e83) to head (d719f8e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1391   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files          50       50           
  Lines        3522     3522           
=======================================
  Hits         2767     2767           
  Misses        755      755           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Benchmarks @ d719f8e

==================================================================================================
                                              eval                       gradient                 
                                           ----------  -------------------------------------------
Model                       dim    linked      primal     FwdDiff    RvsDiff    Mooncake    Enzyme
--------------------------------------------------------------------------------------------------
Simple assume observe         1     false     5.96 ns       10.66    1056.38       30.64      6.48
Simple assume observe         1      true     21.4 ns        3.00     347.97        8.90      1.78
Smorgasbord                 201     false     6.21 μs       71.06     133.91        6.40      6.91
Smorgasbord                 201      true     8.82 μs       64.87     130.75        5.13      4.59
Loop univariate 1k         1000     false     18.7 μs     1153.40     301.11        8.47      6.86
Loop univariate 1k         1000      true     20.2 μs     1506.20     281.80        7.80      6.55
Multivariate 1k            1000     false     25.0 μs      294.15      69.29        7.89      1.96
Multivariate 1k            1000      true     23.9 μs      281.11      73.63        9.14      1.95
Loop univariate 10k       10000     false    175.0 μs    14545.46     347.58        9.18      7.15
Loop univariate 10k       10000      true    197.0 μs    13334.12     313.82        8.21      6.40
Multivariate 10k          10000     false    221.0 μs     4250.86      86.29        9.67      1.81
Multivariate 10k          10000      true    221.0 μs     4211.33      81.89        9.82      1.81
Dynamic                      15     false     1.42 μs         err      40.24       12.73     10.62
Dynamic                      10      true     1.94 μs        1.92      56.58       10.50     17.40
Submodel                      1     false     5.97 ns       10.96    1234.62       30.75      6.41
Submodel                      1      true     5.97 ns       10.75    1419.06       34.60      6.41
LDA                          12      true     22.2 μs        0.49       2.11       31.46       err
==================================================================================================

Each row times one of DynamicPPL's reference models on this PR's head. Dim is the parameter count; Linked is true when parameters have been mapped to unconstrained space. t(logdensity) is the wall-clock time for one log-density evaluation. The AD (automatic differentiation) backend columns express gradient time as a multiple of t(logdensity) — a value of 10 means computing the gradient takes 10× as long as the log-density. Lower is better throughout; err means the backend errored on that model. Compare against main below to spot regressions.

Main @ 8f52e83
==================================================================================================
                                              eval                       gradient                 
                                           ----------  -------------------------------------------
Model                       dim    linked      primal     FwdDiff    RvsDiff    Mooncake    Enzyme
--------------------------------------------------------------------------------------------------
Simple assume observe         1     false     5.88 ns       10.19    1227.40       28.70      6.29
Simple assume observe         1      true     23.9 ns        2.51     325.65        7.06      1.57
Smorgasbord                 201     false     6.46 μs       67.95     123.20        6.29      8.78
Smorgasbord                 201      true     8.91 μs       64.14     130.63        5.11      5.83
Loop univariate 1k         1000     false     19.6 μs      944.58     265.14        7.06      5.81
Loop univariate 1k         1000      true     21.8 μs     1203.52     253.52        6.74      5.40
Multivariate 1k            1000     false     23.4 μs      359.40      74.42        9.16      3.11
Multivariate 1k            1000      true     27.5 μs      276.20      62.49        8.08      3.03
Loop univariate 10k       10000     false    204.0 μs    10171.91     284.39        7.07      5.68
Loop univariate 10k       10000      true    221.0 μs    10195.97     263.81        6.69      5.34
Multivariate 10k          10000     false    222.0 μs     4940.32      81.50       10.28      2.12
Multivariate 10k          10000      true    223.0 μs     4743.12      82.19       10.35      2.12
Dynamic                      15     false     1.43 μs         err      42.49       12.78     10.48
Dynamic                      10      true     1.95 μs        1.97      57.07       17.52     17.92
Submodel                      1     false     5.88 ns       10.20    1254.53       28.97      6.26
Submodel                      1      true     5.88 ns       10.38    1373.22       28.79      6.42
LDA                          12      true     22.3 μs        0.52       2.05       33.24       err
==================================================================================================
Environment
Julia Version 1.11.9
Commit 53a02c0720c (2026-02-06 00:27 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 9V74 80-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver4)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

@yebai yebai merged commit e2d4b5d into main May 8, 2026
17 of 23 checks passed
@yebai yebai deleted the issue-1389 branch May 8, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Benchmark comments are duplciated

2 participants