Override optimize_marginal! for LogDensityFunctionWrapper#1395
Conversation
Rebuild the OptimizationProblem on each call so that updated non-marginalized parameters are passed through to Optimization.jl. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
DynamicPPL.jl documentation for PR #1395 is available at: |
Benchmarks @ c5b64aeEach row times one of DynamicPPL's reference models on this PR's head. Main @ e2d4b5dEnvironmentJulia Version 1.11.9 Commit 53a02c0720c (2026-02-06 00:27 UTC) Build Info: Official https://julialang.org/ release Platform Info: OS: Linux (x86_64-linux-gnu) CPU: 4 × AMD EPYC 7763 64-Core Processor WORD_SIZE: 64 LLVM: libLLVM-16.0.6 (ORCJIT, znver3) Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
==========================================
+ Coverage 78.56% 82.30% +3.73%
==========================================
Files 50 50
Lines 3522 3543 +21
==========================================
+ Hits 2767 2916 +149
+ Misses 755 627 -128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bumps the patch version following #1395
Fix test errors on
main.Adds a
MarginalLogDensities.optimize_marginal!method specialised onLogDensityFunctionWrapperso the OptimizationProblem is rebuilt with the current non-marginalised parametersp2on each call, rather than reusing a stale problem.