Drop unnecessary depwarn + fix Turing tests

[torfjelde]

This PR fixes the performance regressions seen for Emcee in TuringLang/Turing.jl#1900.

@yebai @devmotion This should be an easy merge.

[devmotion]

I'm curious, where and how do we hit this function? The deprecation warning seems to indicate we shouldn't call it and (maybe) we should rather fix wherever we call it?

[torfjelde]

Now link! and invlink! are just depwarn followed by a call to _link! and _invlink!, respectively. When implementing this, I mistakenly also included the depwarn from the link! in one of the _link! implementations. So we're hitting it because I made a typo.

[devmotion]

Ah OK, now I understand 🙂

[torfjelde]

bors r+

[bors]

Build failed:

• test (1, ubuntu-latest, x64, 1)

[torfjelde]

Cause of tests breaking: JuliaDiff/ForwardDiff.jl#606

[yebai]

Please feel free to merge it manually - you need to temporarily change GitHub setting to do that.

[torfjelde]

I don't think I have the rights to do that @yebai ? At least I can't find it here in the project.

[yebai]

I merged it manually - there is an option "Do not allow bypassing the above settings" in branch protection. If you disable that, it allows you to merge PRs by hand.