Bump minor version#1909
Merged
Merged
Conversation
yebai
approved these changes
Nov 14, 2022
yebai
left a comment
yebai
left a comment
Member
There was a problem hiding this comment.
thanks @torfjelde - looks sensible to make a breaking release!
FYI @ChrisRackauckas, in case SciML hook into any DynamicPPL internals. We are in the process of making DynamicPPL core data structure more transparent, performant and hackable, but it might cause some disruptions along the process.
Pull Request Test Coverage Report for Build 3461612003
💛 - Coveralls |
Codecov ReportBase: 81.24% // Head: 81.24% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1909 +/- ##
=======================================
Coverage 81.24% 81.24%
=======================================
Files 21 21
Lines 1418 1418
=======================================
Hits 1152 1152
Misses 266 266 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #1900 we should, IMO, bump the minor version given that we did so in DPPL. Technically this should be non-breaking, but I'm personally worried that there will be some unforeseen consequences OR people are simply using some internal functionality from DPPL (which did have a breaking release).