Updated README#18
Open
SomeGuyEight wants to merge 4 commits into
Open
Conversation
ChallengeCommand: - Refactored ChallengeRequest record with min/max level & handicap - Refactored ChallengeCommand.register to have 12 versions (TODO: Refactor to be more flexible & concise) - Refactored ChallengeCommand.challengePlayer to include min/max level & handicap - Added check in ChallengeCommand.challengePlayer to clamp minLevel to maxLevel - Refactored notification format in ChallengeCommand.challengePlayer to display level range & handicap to challengedPlayer ChallengeUtil: - Refactored ChallengeUtil.createChallengeRequest to intake min/maxLevel & handicap - Added method ChallengeUtil.getBattlePokemonAdjustedLevel to handle each individual pokemon level according to min/maxLevel, handicap, & clamp to (1,100) LeadPokemonSelectionSession: - Refactored LeadPokemonSelectionSession.beginBattle to use min/maxLevel & handicap to pokemon LeadPokemonMenuProvider: - Refactored LeadPokemonMenuProvider.setupPokemonRepresentation to apply min/maxLevel & handicap to pokemon ChallengeBattleBuilder: - Refactored ChallengeBattleBuilder.lvlxpvp to intake & pass min/maxLevel & handicap to ChallengeBattleBuilder.createBattleTeamFromParty - Refactored ChallengeBattleBuilder.createBattleTeamFromParty to apply min/maxLevel & handicap to pokemon (cherry picked from commit 16970ff)
Modified README including min/maxLevel & handicap explanations.
Contributor
Author
|
Sorry, small formatting issue with the command order. I updated the README here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Here is my best shot at updating the README with the changes. If you end up including my commits in the main project, feel free to edit this as you see fit!