First stab at making scaling for ui design purposes possible.#907
Draft
mklaehn wants to merge 1 commit intoTweetWallFX:masterfrom
Draft
First stab at making scaling for ui design purposes possible.#907mklaehn wants to merge 1 commit intoTweetWallFX:masterfrom
mklaehn wants to merge 1 commit intoTweetWallFX:masterfrom
Conversation
svenreimers
reviewed
Oct 30, 2019
Contributor
svenreimers
left a comment
svenreimers
left a comment
There was a problem hiding this comment.
Nice idea. What about different aspect ratios? How do we deal with them? Maybe just supply different subconfigurations (4:3, 16:9, 16:10) in the config and select by determining from the real screen size during start up?
| ), super.toString()); | ||
| } | ||
|
|
||
| public static final class Rectangle { |
Contributor
There was a problem hiding this comment.
Can we use javafx.geometry.Dimension2D instead of creating our own little helper class?
Contributor
Author
There was a problem hiding this comment.
I believe we could. I had some more properties in that class while working on this. However up to this point those properties weren't needed anymore.
mklaehn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.