docs: landing accuracy fixes + README copyright (license/version/watcher/tests/anchors)#46
Conversation
Audited index.html against the code + canonical facts and fixed every confirmed staleness: - Footer license: "github · MIT" → "github · Apache-2.0" (LICENSE is Apache-2.0). - §06 Run desktop: "v0.1.0 release" → "v0.1.2 release", noted signed & notarized + added the Homebrew one-liner. - Watcher mischaracterized as "notify" in 3 places (it polls, ~60 s — watcher.rs explicitly does NOT use notify/FSEvents) → "~60 s poll". Also the Surfaces "12 s poller" → "~60 s poller". - §06 Run docker test count "283 lib + 5 integration" → "294 unit + integration + E2E". - §02 arch detail: "27 unit" → "31 unit" (companion.rs has 31 #[test]; matches the JS panel which already said 31). - Footer dead link: /blob/main/CHANGELOG.md (no such file) → /releases. - Footer "memex install all" anchor #install (gone in the rewritten README) → #quick-start. Left as intentional illustration (not shipped-behavior claims): the animated topology galaxy stat chips and the Companion/Wrapped demo latency/corpus figures. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 46 minutes and 55 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Walkthrough
Changes문서 및 메타데이터 동기화
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in index.html to reflect recent project changes. Key updates include changing the file watcher and poller descriptions from notify / 12s to a ~60 s poll, updating the test counts, referencing the v0.1.2 release with Homebrew Cask installation instructions, changing the license mention from MIT to Apache-2.0, and correcting several links. No review comments were provided, so there is no feedback to address.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@index.html`:
- Line 4318: 문구 "Auto-indexes on save (~60 s poll · content-hash dedup)"가 이벤트
기반(on save)과 폴링 기반을 혼용하므로 문서를 일관되게 폴링 방식으로 수정하세요: 해당 텍스트(예: "Auto-indexes on
save (~60 s poll · content-hash dedup)")를 폴링 전용 표현으로 바꿔 "Auto-indexes (≈60 s
poll · content-hash dedup)" 또는 "Auto-indexes via 60s polling (content-hash
dedup)" 같은 단일한 폴링 문구로 교체해 주세요.
- Around line 4311-4313: The HTML shows a mismatch between the anchor href
"https://github.com/Two-Weeks-Team/memex/releases/latest" and the visible text
"v0.1.2 release"; update either the href or the text so they match: either
change the href to the specific tag URL for v0.1.2 (so the anchor and the fixed
version remain consistent) or change the link text to a non-versioned phrase
like "latest release" (so it matches the releases/latest URL); adjust the <a>
element text next to the <code>.dmg</code> and the brew instruction accordingly
(search for the anchor element around "releases/latest" and the adjacent "v0.1.2
release" text).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
- Version label on the /releases/latest link was hardcoded 'v0.1.2 release', which drifts on the next release → make it version-agnostic 'latest release' (still notes signed & notarized). - 'Auto-indexes on save' contradicted '~60 s poll' (on-save implies event-driven, but it polls) → 'Auto-indexes new sessions (~60 s poll · content-hash dedup)'; also dropped 'on save' from the run-side paragraph. Refs PR #46 review comments
Align the README license attribution with the landing footer ("Two-Weeks-Team")
and the repo org. The LICENSE file is stock Apache-2.0 with no name filled in,
so there is no LICENSE/README conflict — this is just the attribution string.
Bundled with the landing accuracy pass (PR #46) as a consistency fix.
sgwannabe
changed the title
1 participant
Accuracy pass on
index.html(landing served at memex.quest), found via a 3-dimension audit against the code + canonical facts. Content-only; merging redeploys via the deploy-landing workflow.Fixed
github · MIT→github · Apache-2.0(LICENSE is Apache-2.0).v0.1.0 release→v0.1.2 release, noted signed & notarized + addedbrew install --cask two-weeks-team/tap/memex.notifywatcher in 3 spots — code polls (~60 s) and explicitly does not use notify/FSEvents (watcher.rs:15,lib.rs:80 unwrap_or(60)) →~60 s poll. Surfaces12 s poller→~60 s poller.283 lib + 5 integration→294 unit + integration + E2E.27 unitvs JS31 unit→ unified to31(companion.rs has 31#[test])./blob/main/CHANGELOG.md(404 — no such file) →/releases.memex install all→#install(gone in the rewritten README) →#quick-start.Verified-correct, left alone
memex_sessions_v3, fastembed 5.15, MCP "12 tools (11 read + 1 write)", "8 vector slots", Qdrant 1.18/Docker 1.18.1, og/twitter meta tags (present on main).Intentionally left (illustrative, not shipped-behavior claims)
Animated topology galaxy stat chips (stylized ~75-node scene) and Companion/Wrapped demo latency/corpus figures. Can align to the 80-session corpus on request.
🤖 Generated with Claude Code
Summary by CodeRabbit