fix: connect wallet triggers Freighter and shows not-installed modal#342
Open
spiffamani wants to merge 4 commits into
Open
fix: connect wallet triggers Freighter and shows not-installed modal#342spiffamani wants to merge 4 commits into
spiffamani wants to merge 4 commits into
Conversation
- Use requestAccess() instead of getAddress() in WalletContext connect() so clicking Connect Wallet actually triggers the Freighter popup - Add FreighterNotInstalledModal component in WalletModal.tsx that shows when Freighter is not installed, with an Install Freighter CTA - Show modal immediately if isFreighterInstalled is already false - Show modal when connectError contains 'not installed' - Remove duplicate jest.config.ts to fix multiple config conflict
|
Someone is attempting to deploy a commit to the DaniBravo Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Please fix conflicts |
|
@spiffamani Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
added 2 commits
July 4, 2026 09:55
…unt link, fix Freighter install detection
…freighter # Conflicts: # frontend/components/WalletModal.tsx
Owner
|
@spiffamani Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #282
Problem
Clicking "Connect Wallet" did nothing because WalletContext.connect()
called walletService.getAddress() which silently reads the current
address without triggering the Freighter popup.
When Freighter was not installed, the error only appeared as a small
dismissible banner — not a proper user-facing prompt.
Fix
WalletContext.tsx: Changed connect() to use requestAccess() whichopens the Freighter extension popup
WalletModal.tsx: Added FreighterNotInstalledModal that shows whenFreighter is not detected, with a direct Install Freighter link
Tests
13 passing tests in WalletModal.test.ts covering the wallet service
interface and connection flow.