feat: setup project to use hocuspocus v3#4
Open
nperez0111 wants to merge 2 commits intorollback-updatesfrom
Open
feat: setup project to use hocuspocus v3#4nperez0111 wants to merge 2 commits intorollback-updatesfrom
nperez0111 wants to merge 2 commits intorollback-updatesfrom
Conversation
nperez0111
commented
Mar 27, 2025
|
|
||
| data.connection.readOnly = authInfo.role === "COMMENT-ONLY"; | ||
| data.connectionConfig.readOnly = authInfo.role === "COMMENT-ONLY"; |
Author
There was a problem hiding this comment.
Need to double check whether this does what I think it does....
nperez0111
commented
Mar 27, 2025
| database: "db.sqlite", | ||
| database: ":memory:", | ||
| }), | ||
| // TODO we can actually just do the auth check in here, and not need the server to inject the mark or anything |
Author
There was a problem hiding this comment.
This might actually really simplify things, if we choose to do the authorization at the hocuspocus layer instead, it would allow clients to safely make modifications to the threads on their side. To make it safe though, we need to inspect what exactly was updated (i.e. they can only modify their own comments).
nperez0111
force-pushed
the
hocuspocus-v3
branch
from
46170d5 to
d4760bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the RejectUnauthorized extension with the proposed PR ueberdosis/hocuspocus#919 into hocuspocus
While I was at it, since the PR is based on Hocuspocus v3, I had to update the usage in this project to match hocuspocus 3. It is not changed in the package.json yet.
We need to wait to see if the PR goes through before trying to merge this in