Skip to content

fix: remove dependency array from comments re-rendering #6291

fix: remove dependency array from comments re-rendering

fix: remove dependency array from comments re-rendering #6291

Triggered via pull request November 14, 2025 09:59
Status Success
Total duration 8m 22s
Artifacts 4

build.yml

on: pull_request
Matrix: playwright
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 4 notices
[webkit] › src/end-to-end/basics/basicblocks.test.ts:11:7 › Check basic text block appearance › Check basic text block appearance: tests/src/end-to-end/basics/basicblocks.test.ts#L19
1) [webkit] › src/end-to-end/basics/basicblocks.test.ts:11:7 › Check basic text block appearance › Check basic text block appearance Error: locator.click: Test timeout of 30000ms exceeded. Call log: - waiting for locator('[data-content-type="video"] .bn-file-caption') 17 | await page.waitForTimeout(500); 18 | > 19 | await page.locator(`[data-content-type="video"] .bn-file-caption`).click(); | ^ 20 | await page.keyboard.press("Backspace"); 21 | await page.waitForTimeout(500); 22 | at /__w/BlockNote/BlockNote/tests/src/end-to-end/basics/basicblocks.test.ts:19:72
[webkit] › src/end-to-end/basics/basicblocks.test.ts:11:7 › Check basic text block appearance › Check basic text block appearance: tests/src/end-to-end/basics/basicblocks.test.ts#L0
1) [webkit] › src/end-to-end/basics/basicblocks.test.ts:11:7 › Check basic text block appearance › Check basic text block appearance Test timeout of 30000ms exceeded.
[firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:117:7 › Check SlashMenu Functionality › Should be able to create complex documents that match snapshots: tests/src/utils/editor.ts#L47
5) [firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:117:7 › Check SlashMenu Functionality › Should be able to create complex documents that match snapshots Error: expect(string).toMatchSnapshot(expected) @@ -38,11 +38,11 @@ "type": "heading", "attrs": { "backgroundColor": "default", "textColor": "default", "textAlignment": "left", - "level": 2, + "level": 1, "isToggleable": false }, "content": [ { "type": "text", @@ -63,11 +63,11 @@ "type": "heading", "attrs": { "backgroundColor": "default", "textColor": "default", "textAlignment": "left", - "level": 3, + "level": 1, "isToggleable": false }, "content": [ { "type": "text", Expected: /__w/BlockNote/BlockNote/tests/src/end-to-end/slashmenu/slashmenu.test.ts-snapshots/docStructureSnapshot-firefox-linux.json Received: /__w/BlockNote/BlockNote/tests/test-results/slashmenu-slashmenu-Check--f99af-uments-that-match-snapshots-firefox/docStructureSnapshot-actual.json at ../utils/editor.ts:47 45 | // Remove id from docs 46 | const doc = JSON.stringify(await getDoc(page), null, 2); > 47 | expect(doc).toMatchSnapshot(`${name}.json`); | ^ 48 | } 49 | at compareDocToSnapshot (/__w/BlockNote/BlockNote/tests/src/utils/editor.ts:47:15) at /__w/BlockNote/BlockNote/tests/src/end-to-end/slashmenu/slashmenu.test.ts:141:5
[firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:42:7 › Check SlashMenu Functionality › Should be able to create h3: tests/src/utils/editor.ts#L11
4) [firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:42:7 › Check SlashMenu Functionality › Should be able to create h3 TimeoutError: locator.waitFor: Timeout 1000ms exceeded. Call log: - waiting for locator('.bn-editor').locator('[data-content-type=heading][data-level="3"]') at ../utils/editor.ts:11 9 | export async function waitForSelectorInEditor(page: Page, selector: string) { 10 | const editor = page.locator(EDITOR_SELECTOR); > 11 | await editor.locator(selector).waitFor({ | ^ 12 | state: "attached", 13 | timeout: 1000, 14 | }); at waitForSelectorInEditor (/__w/BlockNote/BlockNote/tests/src/utils/editor.ts:11:34) at /__w/BlockNote/BlockNote/tests/src/end-to-end/slashmenu/slashmenu.test.ts:46:34
[firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:36:7 › Check SlashMenu Functionality › Should be able to create h2: tests/src/utils/editor.ts#L11
3) [firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:36:7 › Check SlashMenu Functionality › Should be able to create h2 TimeoutError: locator.waitFor: Timeout 1000ms exceeded. Call log: - waiting for locator('.bn-editor').locator('[data-content-type=heading][data-level="2"]') at ../utils/editor.ts:11 9 | export async function waitForSelectorInEditor(page: Page, selector: string) { 10 | const editor = page.locator(EDITOR_SELECTOR); > 11 | await editor.locator(selector).waitFor({ | ^ 12 | state: "attached", 13 | timeout: 1000, 14 | }); at waitForSelectorInEditor (/__w/BlockNote/BlockNote/tests/src/utils/editor.ts:11:34) at /__w/BlockNote/BlockNote/tests/src/end-to-end/slashmenu/slashmenu.test.ts:40:34
[firefox] › src/end-to-end/draghandle/draghandle.test.ts:161:7 › Check Draghandle functionality › Deleting block with children should delete all children: tests/src/end-to-end/draghandle/draghandle.test.ts#L175
2) [firefox] › src/end-to-end/draghandle/draghandle.test.ts:161:7 › Check Draghandle functionality › Deleting block with children should delete all children Error: page.hover: Target page, context or browser has been closed Call log: - waiting for locator('[data-content-type=heading][data-level="2"]') 173 | await page.keyboard.type("This is h3"); 174 | > 175 | await page.hover(H_TWO_BLOCK_SELECTOR); | ^ 176 | await page.click(DRAG_HANDLE_SELECTOR); 177 | await page.click("text=Delete"); 178 | await page.waitForSelector(H_ONE_BLOCK_SELECTOR); at /__w/BlockNote/BlockNote/tests/src/end-to-end/draghandle/draghandle.test.ts:175:16
[firefox] › src/end-to-end/draghandle/draghandle.test.ts:161:7 › Check Draghandle functionality › Deleting block with children should delete all children: tests/src/end-to-end/draghandle/draghandle.test.ts#L0
2) [firefox] › src/end-to-end/draghandle/draghandle.test.ts:161:7 › Check Draghandle functionality › Deleting block with children should delete all children Test timeout of 30000ms exceeded.
[firefox] › src/end-to-end/draghandle/draghandle.test.ts:143:7 › Check Draghandle functionality › Delete button should delete correct block: tests/src/end-to-end/draghandle/draghandle.test.ts#L151
1) [firefox] › src/end-to-end/draghandle/draghandle.test.ts:143:7 › Check Draghandle functionality › Delete button should delete correct block Error: page.hover: Target page, context or browser has been closed Call log: - waiting for locator('[data-content-type=heading][data-level="2"]') 149 | await page.keyboard.type("This is h3"); 150 | > 151 | await page.hover(H_TWO_BLOCK_SELECTOR); | ^ 152 | await page.click(DRAG_HANDLE_SELECTOR); 153 | await page.click("text=Delete"); 154 | await page.waitForSelector(H_ONE_BLOCK_SELECTOR); at /__w/BlockNote/BlockNote/tests/src/end-to-end/draghandle/draghandle.test.ts:151:16
[firefox] › src/end-to-end/draghandle/draghandle.test.ts:143:7 › Check Draghandle functionality › Delete button should delete correct block: tests/src/end-to-end/draghandle/draghandle.test.ts#L0
1) [firefox] › src/end-to-end/draghandle/draghandle.test.ts:143:7 › Check Draghandle functionality › Delete button should delete correct block Test timeout of 30000ms exceeded.
Build
{ "workflowData": { "owner": "TypeCellOS", "repo": "BlockNote", "sha": "3731ac9246beb071fec7dd6084a11ade8e1c292e", "ref": "2177" }, "key": "9RlIMgXT43", "runId": 19360978586, "webhookDebug": { "action": "requested", "head_branch": "comments-rerender", "head_repository_full_name": "TypeCellOS/BlockNote", "full_name": "TypeCellOS/BlockNote", "isPullRequest": true, "prNumber": 2177, "prNumberType": "number", "isNewPullRequest": true, "isOldPullRequest": false, "prKey": "TypeCellOS/BlockNote:comments-rerender", "oldPrDataHash": "xHluIIJbco", "lookupKey": "TypeCellOS/BlockNote:comments-rerender", "data": { "owner": "TypeCellOS", "repo": "BlockNote", "sha": "3731ac9246beb071fec7dd6084a11ade8e1c292e", "ref": "2177" } } }
🎭 Playwright Run Summary
1 skipped 94 passed (2.2m)
🎭 Playwright Run Summary
1 flaky [webkit] › src/end-to-end/basics/basicblocks.test.ts:11:7 › Check basic text block appearance › Check basic text block appearance 9 skipped 85 passed (3.6m)
🎭 Playwright Run Summary
5 flaky [firefox] › src/end-to-end/draghandle/draghandle.test.ts:143:7 › Check Draghandle functionality › Delete button should delete correct block [firefox] › src/end-to-end/draghandle/draghandle.test.ts:161:7 › Check Draghandle functionality › Deleting block with children should delete all children [firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:36:7 › Check SlashMenu Functionality › Should be able to create h2 [firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:42:7 › Check SlashMenu Functionality › Should be able to create h3 [firefox] › src/end-to-end/slashmenu/slashmenu.test.ts:117:7 › Check SlashMenu Functionality › Should be able to create complex documents that match snapshots 11 skipped 79 passed (3.9m)

Artifacts

Produced during runtime
Name Size Digest
playwright-report-chromium Expired
263 KB
sha256:80c66c95566e8e1f6a25acf096785fffaa638349dc9e6b8a5b817414351b78d2
playwright-report-firefox Expired
2.31 MB
sha256:a2d21efa3f8d8a6a48666ce41bd7a154344cafe8a581da215b0d19d3e0ff75c6
playwright-report-webkit Expired
2.1 MB
sha256:6a8bd125fb876a6ccf377580eaf88298102be57a68ea46a9f1cf627381695d2f
relative-ci-artifacts-editor Expired
45.5 KB
sha256:5909a0feeab59623c9f914454b259f55f73b398d2d0c6a05cddecb695bdc1448