fix: remove dependency array from comments re-rendering#2177
Merged
nperez0111 merged 2 commits intomainfrom Nov 18, 2025
Merged
fix: remove dependency array from comments re-rendering#2177nperez0111 merged 2 commits intomainfrom
nperez0111 merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
ed58642 to
f6b6dd4
Compare
f6b6dd4 to
3731ac9
Compare
3731ac9 to
746b15a
Compare
YousefED
approved these changes
Nov 18, 2025
Collaborator
YousefED
left a comment
There was a problem hiding this comment.
I think you're right. Can you make sure with manual testing this doesn't cause stale data outside of the edge-case you mentioned?
Contributor
Author
|
I've just gone with the React.key, to make doubly sure. This should be exactly the same behavior now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I think that this was being used to allow the editor to re-render if it saw a new comment.body, but the only scenario that I can even imagine that happening is that the same person is logged in on two different browsers & updates their comment on one and has the comment editor open on the other. In that case they will now see a stale value. If we really cared about this case, then we can change the Comments component to use a React.key that forces the Comment component to re-render based on the new comment body content, but I think it is enough of an edge case that it isn't even worth implementing that.
Rationale
Changes
Impact
Testing
Screenshots/Video
Checklist
Additional Notes