Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
nperez0111
left a comment
nperez0111
left a comment
There was a problem hiding this comment.
Pretty straightforward! Nice
There was a problem hiding this comment.
I think you need to update the .bnblock config file or whatever it is called. So that pnpm run gen doesn't overwrite these changes
There was a problem hiding this comment.
Is it not correct as is? In the .bnexample.json file, I updated the Mantine package version under dependencies, which pnpm gen uses to update the dependencies in the corresponding package.json. Or am I misunderstanding?
There was a problem hiding this comment.
Ah maybe I missed it then
| @import url("@mantine/core/styles/TypographyStylesProvider.css"); | ||
| @import url("@mantine/core/styles/Typography.css"); | ||
|
|
||
| /* Mantine baseline styles, scoped to .bn-mantine element. */ |
There was a problem hiding this comment.
are you sure we don't need the other styles from global.css?
There was a problem hiding this comment.
Yes, the global.css file does have some styling for focused elements, but they aren't necessary and in some cases where we use non-Mantine components (like regular divs with FloatingUI), they can look broken:
Default focus style:
Mantine global focus style:
The other styles in global.css are unused within BlockNote.
* Added `withMantineProvider` prop * Ran `pnpm gen` * Made separate component instead of boolean flag * Updated naming * Made `BlockNoteView` render `MantineProvider` only if it's not already within a `MantineContext`
3 participants
This PR updates the Mantine version to v8. There are 2 notable changes with this:
global.csshas now been split into several files, from which we only needbaseline.css. The styles from that file have been copied and scoped to.bn-mantine.