Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
nperez0111
reviewed
Sep 29, 2025
nperez0111
reviewed
Sep 29, 2025
nperez0111
reviewed
Oct 1, 2025
Comment on lines
16
to
28
| import { createStore, StoreApi } from "zustand/vanilla"; | ||
|
|
||
| import { | ||
| aiDocumentFormats, | ||
| buildAIRequest, | ||
| defaultAIRequestSender, | ||
| executeAIRequest, | ||
| } from "./api/index.js"; | ||
| import { createAgentCursorPlugin } from "./plugins/AgentCursorPlugin.js"; | ||
| import { AIRequestHelpers, InvokeAIOptions } from "./types.js"; | ||
|
|
||
| type ReadonlyStoreApi<T> = Pick< | ||
| StoreApi<T>, |
Contributor
There was a problem hiding this comment.
Why wrap in an editor.onCreate? I'm actually uncertain that onCreate gets invoked right now, does it? Is it on mount?
Collaborator
Author
There was a problem hiding this comment.
The underlying TipTap editor is undefined when the extension constructor is run, and so an error gets thrown attempting to call tiptapEditor.on("update", ...) (within editor.onChange(...)). Wrapping it in editor.onCreate fixes this. Maybe onMount would be better than onCreate? Any way that that we can ensure the TipTap editor is already initialized.
Contributor
There was a problem hiding this comment.
We need to fix this then, because I don't think this is a great pattern
nperez0111
reviewed
Oct 1, 2025
nperez0111
reviewed
Oct 1, 2025
… into ai-menu-auto-scroll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.