feat: Shortcut to delete empty table while cells are selected#2052
Merged
matthewlipski merged 4 commits intomainfrom Oct 7, 2025
Merged
feat: Shortcut to delete empty table while cells are selected#2052matthewlipski merged 4 commits intomainfrom
matthewlipski merged 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
nperez0111
reviewed
Oct 2, 2025
nperez0111
reviewed
Oct 2, 2025
nperez0111
reviewed
Oct 6, 2025
Comment on lines
443
to
465
| // Need to use ProseMirror API to check if selection spans table. | ||
| const anchorCellColIndex = | ||
| editor.prosemirrorState.selection.$anchorCell.index(); | ||
| const anchorCellRowIndex = | ||
| editor.prosemirrorState.selection.$anchorCell.index(-1); | ||
| const headCellColIndex = | ||
| editor.prosemirrorState.selection.$headCell.index(); | ||
| const headCellRowIndex = | ||
| editor.prosemirrorState.selection.$headCell.index(-1); | ||
|
|
||
| const minColIndex = Math.min(anchorCellColIndex, headCellColIndex); | ||
| const maxColIndex = Math.max(anchorCellColIndex, headCellColIndex); | ||
| const minRowIndex = Math.min(anchorCellRowIndex, headCellRowIndex); | ||
| const maxRowIndex = Math.max(anchorCellRowIndex, headCellRowIndex); | ||
|
|
||
| if ( | ||
| minColIndex !== 0 || | ||
| maxColIndex !== cols - 1 || | ||
| minRowIndex !== 0 || | ||
| maxRowIndex !== rows - 1 | ||
| ) { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
Did you test this with merged/split cells? I think that it will actually be a bit off since the number of table cells will not be the same as the number of td nodes. I suggest looking at what: getCellSelection does in tableHandlesPlugin, and either use or come up with something similar to that
Collaborator
Author
There was a problem hiding this comment.
I realized this can be done much simpler - the whole table is selected when each cell is selected, meaning we can just check if the number of selected cells is equal to the number of total cells or if it's less.
nperez0111
reviewed
Oct 6, 2025
nperez0111
approved these changes
Oct 7, 2025
Contributor
nperez0111
left a comment
nperez0111
left a comment
There was a problem hiding this comment.
Yep, this is simple enough!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2038