feat: add configurable event handling for SideMenu#2117
Closed
Aslam97 wants to merge 1 commit intoTypeCellOS:mainfrom
Closed
feat: add configurable event handling for SideMenu#2117Aslam97 wants to merge 1 commit intoTypeCellOS:mainfrom
Aslam97 wants to merge 1 commit intoTypeCellOS:mainfrom
Conversation
|
@Aslam97 is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
@Aslam97 thanks for this, but I don't think this is the direction of where we want to go in exposing this configuration. For one, this should be known upfront, so the useEffect feels like a hack, than a supported solution. Secondly, I don't know that it is worth it to switch between which API to use just for this. Instead of listening to the root level element this should switch to the editor dom element instead & listen on that, so no need for handleDOMEvents api which does essentially the same thing as an addEventListener would |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR demonstrates how to scope the mouse tracking inside the editor by providing an opt-in mechanism to use ProseMirror's
handleDOMEventsinstead of root-level event listeners.Summary
Adds a configurable
useHandleDOMEventsoption to the SideMenu plugin, allowing users to choose between two event handling strategies for mouse tracking.Rationale
Issue here #1016
Changes
Impact
Testing
Screenshots/Video
Checklist
Additional Notes