fix: Improper accessing of editor DOM element#2234
Merged
nperez0111 merged 3 commits intomainfrom Dec 9, 2025
Merged
Conversation
…ditor.domElement`.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
YousefED
approved these changes
Dec 5, 2025
nperez0111
approved these changes
Dec 8, 2025
Contributor
nperez0111
left a comment
There was a problem hiding this comment.
Ah, right I forgot I added that API
nperez0111
requested changes
Dec 8, 2025
Contributor
nperez0111
left a comment
There was a problem hiding this comment.
Can we clean up the other instances of this too, it definitely is pointing to a larger problem
nperez0111
approved these changes
Dec 9, 2025
Contributor
nperez0111
left a comment
There was a problem hiding this comment.
This did have all the instances covered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the editor DOM element being read from
editor.prosemirrorView.domElementtoeditor.domElementin some places. Especially in theCreateLinkButtoncomponent, this is an important distinction as the DOM element doesn't exist when the component is cleaning up, leading to errors.closes #2189
Rationale
The
CreateLinkButtoncomponent will throw an error if it's being unmounted with the editor view.Changes
See above.
Impact
N/A
Testing
N/A
Screenshots/Video
N/A
Checklist
Additional Notes