fix(ai): make sure ShowSelection works#2297
Merged
nperez0111 merged 1 commit intomainfrom Jan 8, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
12c5d16 to
522a939
Compare
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
nperez0111
approved these changes
Jan 8, 2026
Contributor
nperez0111
left a comment
There was a problem hiding this comment.
I think I would prefer a slightly different approach here:
commands:
- showSelection(key: string)
- hideSelection(key: string)
But, honestly it is a minor thing. I would probably revisit the naming of this altogether on second though. Like PreserveSelectionExtension with show & hide methods
But, I'd rather just fix the bug for now and revisit later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
showSelection(false)effect cleanup in the Link button was interfering with the AI extension. What happened:showSelection(true)showSelection(false)Rationale
This keys the
showSelectionby "consumer". @nperez0111 let me know what you think if this, open to other solutionsChanges
Impact
Testing
Manual
Checklist