fix(link-toolbar): prevent Enter from submitting during IME composition#2361
Merged
nperez0111 merged 2 commits intoTypeCellOS:mainfrom Jan 27, 2026
Merged
Conversation
|
@hanios123 is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
This is great @hanios123 I would merge this, but I'd probably go around to check whether we have this issue in other places or not first. And I don't have the time to dive into that at this time. |
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
… already have it
matthewlipski
approved these changes
Jan 27, 2026
Contributor
|
Thanks @matthewlipski this is exactly what I'd have expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent the link toolbar form from submitting when the user presses Enter during IME (Input Method Editor) composition.
Rationale
When users type in languages that require IME input methods (e.g., Japanese, Chinese, Korean), they press Enter to confirm character conversions (e.g., converting hiragana to kanji). Without this fix, pressing Enter during composition would prematurely submit the link form instead of completing the character input, breaking the editing experience for CJK users.
Changes
Impact
Testing
Screenshots/Video
Screen.Recording.2026-01-15.at.11.03.09.mov
Checklist