Skip to content

fix: table handles would crash #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewlipski merged 1 commit into from
Jan 27, 2026
+6 −2
Merged

fix: table handles would crash #2384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/core/src/extensions/TableHandles/TableHandles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,9 +296,13 @@ export class TableHandlesView implements PluginView {
event.clientX >= tableRect.right - 1 &&
event.clientX < tableRect.right + 20;

// without this check, we'd also hide draghandles when hovering over them
const hideHandles =
event.clientX > tableRect.right || event.clientY > tableRect.bottom;
// always hide handles when the actively hovered table changed
this.state?.block.id !== tableBlock.id ||
// make sure we don't hide existing handles (keep col / row index) when
// we're hovering just above or to the right of a table
event.clientX > tableRect.right ||
event.clientY > tableRect.bottom;

this.state = {
...this.state!,
Expand Down
Loading