Open
Conversation
…into sauravbanna/add_fullsystem_stats
Andrewyx
changed the base branch from
sauravbanna/add_fullsystem_stats
to
master
…into sauravbanna/add_stat_trackers
Andrewyx
approved these changes
Mar 14, 2026
nycrat
reviewed
Mar 16, 2026
Member
nycrat
left a comment
nycrat
left a comment
There was a problem hiding this comment.
Forgot to click submit review on saturday 🫡
Mostly just adding doc comments, especially constructors and public methods
Member
There was a problem hiding this comment.
should have doc comment for __init__
Comment on lines
+11
to
+13
| # tune these values to reduce noise in what is considered a kick | ||
| # higher values exclude noise such as dribbling or small movements of the ball | ||
| # but can exclude real kicks |
| callback: Callable[[bool, bool], None], | ||
| buffer_size: int = 5, | ||
| ): | ||
| super().__init__(callback=callback, buffer_size=buffer_size) |
Member
There was a problem hiding this comment.
should have doc comment for __init__
| ) | ||
|
|
||
| py_library( | ||
| name = "tracker_module", |
Member
There was a problem hiding this comment.
potentially just name this library tracker and get rid of the other ones since we only really need to expose this library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the stats module to add a
trackersmodule, containing individual trackers, each responsible for tracking a specific part of the game stateThis makes it more modular and easier to add more stats related logging in the future, as we can reuse the tracking logic in multiple places.
Testing Done
Compiles, and existing stats are tracked correctly
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue