Automate handling referee game events#3643
Merged
nycrat merged 20 commits intoUBC-Thunderbots:masterfrom Mar 15, 2026
Merged
Conversation
nycrat
force-pushed
the
avah/automate_manual_referee_commands
branch
from
4c8dcbb to
0de03a7
Compare
nycrat
force-pushed
the
avah/automate_manual_referee_commands
branch
from
835ac60 to
b9df062
Compare
nycrat
changed the title
nycrat
commented
Mar 13, 2026
src/software/thunderscope/binary_context_managers/game_controller.py
Outdated
Show resolved
Hide resolved
nycrat
requested review from
Andrewyx,
sauravbanna and
williamckha
as code owners
Andrewyx
previously approved these changes
Mar 15, 2026
…te_game_stage_changes
Andrewyx
approved these changes
Mar 15, 2026
3 tasks
StarrryNight
pushed a commit
that referenced
this pull request
Mar 21, 2026
* Implement auto approving goals * Re-write code to be a bit cleaner * Re-initialize world state after ball placement failure * Make sure teams get reset with proper amount of robots * Set only ball to ball placement point when failed * Remove unused import * Separate automate_referee method into helpers * Add comments * Implement auto start second half * Add call to automate_stage_change * Fix copying enum * Refactor method a bit * Implement starting new game * Uncomment call to automate_referee, move after updating latest world * Refactor a bit * Extract helper function for handling stage change * Add doc comment * Let both teams do ball placement before manual placement * Get rid of magic number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an
__automate_refereemethod to the gamecontroller binary context manager class that handles referee game events for POSSIBLE_GOAL and FAILED_PLACEMENT. This automates two common human referee interventions so that the game will continue by itself.Testing Done
Ran
./tbots.py run thunderscope_main --enable_autoref(uncommented__automate_refereemethod call) and:approve_goal.mov
placement_failed.mov
Resolved Issues
Part of #3633, resolves #3625
Length Justification and Key Files to Review
N/A
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue