Reduce boilerplate for setting tactics and plays in tests#3648
Merged
Reduce boilerplate for setting tactics and plays in tests#3648
Conversation
sauravbanna
previously approved these changes
Mar 14, 2026
src/software/ai/hl/stp/tactic/crease_defender/crease_defender_tactic_test.py
Outdated
Show resolved
Hide resolved
320e9b7 to
ced6821
Compare
abc1836 to
2f5f892
Compare
Andrewyx
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In pytests, setting robot tactics required quite a bit of boilerplate related to creating the
AssignedTacticPlayControlParamsprotos. This PR modifies theset_tacticsandset_playfunctions to reduce repeated code, and also makes the code more readable.Old:
New:
Old:
New:
Testing Done
Behaviour of tests is still the same after the refactors.
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue