Open
Conversation
priyanshumahey
requested changes
Jun 3, 2024
Contributor
priyanshumahey
left a comment
There was a problem hiding this comment.
A couple of changes I'd like to ask for:
- Obtain the SVG and add that to
components/icons/iconsand then use that SVG - Add
use clientat the top of this file - For the prop type, change
({ title }: { title: string })to({ title }: {RunnerClipropsand then create a new type for the props.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Being Made
Purpose of Change:
Here give examples of the changes you've made in this pull request. Include an itemized list if you can.
How to Test?
<div className="p-10"> <RunnerClip title="Python" /> </div>Screenshots (optional)
Screen.Recording.2024-06-02.at.12.15.55.PM.mov