This repository was archived by the owner on Jan 2, 2024. It is now read-only.
Open
Conversation
Member
There was a problem hiding this comment.
Note
- This issue was originally created to ensure that we are always receiving signal from the GPS CAN field. If we don't, the averaging that we do when filtering could break. But this case would never happen right, if GPS CAN stopped working we would just publish the last published data.
Couple questions
- What happens when AIS data isn't changing as well? We could just be dead in the water with no wind
- Should we check occassionally to see if GPS CAN is changing? Or should we just discard it for the future?
- Should we check is CAN GPS is vastly different from AIS?
Member
Author
|
Member
I see in the code that for it to match the latlon has to be the same to at least 4 decimal points. How many decimal points to be get from the GPS's again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Verification