Open
Conversation
Member
|
It seems I've never been notified of this PR, looks like I was not even watching the repo 👀 This patch looks pretty clean and would be easy to keep on top on the upstream branch. I'll check this asap ! |
Author
|
Hi @anthonygego, Just following up on the PR. Let me know if you need anything to proceed. Thanks! |
Member
|
The diff looks a lot like parts of overleaf@986230d and contains the exact same comments for tricky parts. It's worth mentioning all the previous contributors, at least for proving we are doing open-source software right. I'm actually quite concerned by the two |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two features that improve collaboration between authors when writing a paper.