Add evaluate algorithm#145
Merged
Merged
Conversation
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
mscroggs
commented
Jun 26, 2026
willGraham01
requested changes
Jun 29, 2026
willGraham01
left a comment
willGraham01
left a comment
Collaborator
There was a problem hiding this comment.
Main comment is about how evaluate is currently implemented; namely
- It's not a pure function and
- We might want to retrieve multiple values from the graph, some of which are "on the way down". Right now we have to do this through multiple calls.
Beyond that, some comments on organising and expanding the tests.
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
mscroggs
force-pushed
the
mscroggs/evaluate
branch
2 times, most recently
from
619a69e to
6cd17c6
Compare
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
mscroggs
force-pushed
the
mscroggs/evaluate
branch
from
6cd17c6 to
a512b2d
Compare
willGraham01
requested changes
Jun 29, 2026
willGraham01
left a comment
willGraham01
left a comment
Collaborator
There was a problem hiding this comment.
evaluate_down_to is more general than evaluate so we should adapt the test accordingly (though we can test both in the same test because I'm not a code sadist).
Also we might not want to duplicate the values dictionary entries, so have suggested just returning node-evaluations that are actually computed.
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
willGraham01
approved these changes
Jun 29, 2026
| evaluate_test_graph: Graph, | ||
| outcome_node_label: str, | ||
| initial_values: dict[str, Array], | ||
| expected_result: Array, |
Collaborator
There was a problem hiding this comment.
Suggested change
| expected_result: Array, | |
| expected_result: dict[str, float | Array], |
(Soz, but otherwise all looks good!)
Collaborator
Author
There was a problem hiding this comment.
We should work out why mypy didn't spot that one
Collaborator
There was a problem hiding this comment.
Haven't we just blanket disabled typehint checking in the tests (because a lot of our fixtures have very long types)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
evaluatealgorithm that uses theevaluatemethod on each node from the roots down to the outcome node.utilsthat creates the graph for the example model that Ricardo is interested inBuilds on #143.
Resolves #125. Resolves #126.