Resolve the issue of running provision again#1
Open
knight-corvi wants to merge 7 commits intoUCMAndesLab:masterfrom
Open
Resolve the issue of running provision again#1knight-corvi wants to merge 7 commits intoUCMAndesLab:masterfrom
provision again#1knight-corvi wants to merge 7 commits intoUCMAndesLab:masterfrom
Conversation
…s hostname to _tinyOS_ + Adds puppet repository using the DEB package. + Fixes the issue of not having puppet v4 in the ubuntu repositories which is required by the _apt_ module in puppet if installing from the plugin install utility.
It resolves the issue of running provision after a setup. The problem was caused when installing java. See: https://askubuntu.com/questions/769467/can-not-install-openjdk-9-jdk-because-it-tries-to-overwrite-file-aready-includ Adds full fingerprint for _tinyprod_ source and as such it removes the warning about having a short ID. Puts the correct location of _profile_ in _source_
Contributor
|
Could you please add some more descriptions of what exactly you are doing to your pull request. From what I see you did the following:
Vagrant up is not working at the moment since it assumes that a user already has a cse160-networks directory. This vagrant file is designed to be used outside of the class also, but I wouldn't mind having a shared directory. If possible include a way to create this directory without having the user create the directory separately. Besides that, everything seems to work great. Thanks for your contribution. I'll accept once the shared folder stuff is resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my effort to figure out the the issue about having to run
provisiontwice, I made modifications in terms of the structure of the content of the files, mostly spacing between characters and moving inline scripts to variables or files