Skip to content

fix(ui5-illustrated-message): acc findings fixed #13554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PetyaMarkovaBogdanova wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −1
Open

fix(ui5-illustrated-message): acc findings fixed #13554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
586a652
fix(ui5-im): fix acc test findings
PetyaMarkovaBogdanova May 20, 2026
efcb3be
fix(ui5-illustrated-message): kept aria-hidden, test added
PetyaMarkovaBogdanova Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/fiori/cypress/specs/IllustratedMessage.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,4 +296,21 @@ describe("Dot design resource handling", () => {
.find(".ui5-illustrated-message-illustration svg")
.should("have.id", "sapIllus-Dot-AddPeople");
});
});

describe("Utility SVG accessibility", () => {
it("utility SVG has only aria-hidden='true' and no role or focusable attributes", () => {
cy.mount(
<IllustratedMessage name="UnableToUpload" />
);

cy.get("[ui5-illustrated-message]")
.shadow()
.find(".ui5-illustrated-message-util")
.should(($svg) => {
expect($svg).to.have.attr("aria-hidden", "true");
expect($svg).not.to.have.attr("role");
expect($svg).not.to.have.attr("focusable");
});
});
});
2 changes: 1 addition & 1 deletion packages/fiori/src/IllustratedMessageTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default function IllustratedMessageTemplate(this: IllustratedMessage) {
</div>
</div>

<svg xmlns="http://www.w3.org/2000/svg" class="ui5-illustrated-message-util">
<svg xmlns="http://www.w3.org/2000/svg" class="ui5-illustrated-message-util" aria-hidden="true">
<defs>
<pattern id="sapIllus_PatternShadow" data-name="sapIllus_PatternShadow" width="3" height="5.5"
patternUnits="userSpaceOnUse" viewBox="0 0 3 5.5">
Expand Down
Loading