Skip to content

fix(ui5-media-gallery): acc findings fixed #13555

Open
PetyaMarkovaBogdanova wants to merge 2 commits into
mainfrom
fix-acc-mg
Open

fix(ui5-media-gallery): acc findings fixed #13555
PetyaMarkovaBogdanova wants to merge 2 commits into
mainfrom
fix-acc-mg

Conversation

@PetyaMarkovaBogdanova

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova commented May 20, 2026

Copy link
Copy Markdown
Contributor

4) MediaGallery (22 failing)

  • Repeated continuum violations, including:
  • LI with role="option" missing aria-checked (ID 1079).
  • UL child-structure violation for list semantics (ID 246).
  • Failing examples include thumbnail options and overflow scenarios.
Component Issue Not by spec Good to have Spec refs Spec quote sentence Coverage strength
MediaGallery role=option missing required state Likely Yes No ACC-264 "Item in data set has ARIA role=option" and "Selected item should be indicated using aria-selected=true" Indirect (pattern-based)
MediaGallery UL child-structure/list semantics violation Yes No ACC-263 "The structure should be an unordered list containing anchors and separators inside list items" Indirect (list-structure pattern)

@ui5-webcomponents-bot

ui5-webcomponents-bot commented May 20, 2026

Copy link
Copy Markdown
Collaborator

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 20, 2026 07:09 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 20, 2026 07:22 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 20, 2026 12:21 Inactive
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova changed the title Fix acc mg fix(ui5-media-gallery): acc findings fixed May 20, 2026
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova marked this pull request as ready for review May 20, 2026 14:30
@yanaminkova yanaminkova self-requested a review June 10, 2026 11:29

@yanaminkova yanaminkova left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no aria-selected attribute, the correct one is aria-checked.

Adding role="listbox" to the <ul> resolves the current validation error, but it introduces another one related to the overflow button. To satisfy the accessibility requirements, the element with the ui5-media-gallery-overflow class should also have role="option" and an aria-checked attribute.

Could you also please add Cypress tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants