Skip to content

fix(ui5-breadcrumbs): acc findings fixed #13557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PetyaMarkovaBogdanova wants to merge 3 commits into
base: main
Choose a base branch
from
+40 −1
Open

fix(ui5-breadcrumbs): acc findings fixed #13557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c43df2
fix(ui5-breadcrumbs): fix acc finding
PetyaMarkovaBogdanova May 20, 2026
e837486
fix(ui5-breadcrumbs): add accessibleName property to Breadcrumbs comp…
PetyaMarkovaBogdanova Jun 10, 2026
4dbd2e2
fix(ui5-breadcrumbs): fixed typo
PetyaMarkovaBogdanova Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions packages/main/cypress/specs/Breadcrumbs.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,4 +1155,34 @@ describe("BreadcrumbsItem click event", () => {
expect(itemClickFired).to.be.false;
});
});
});

describe("Breadcrumbs - accessibleName property", () => {
it("uses the default 'Breadcrumb Trail' label when accessibleName is not set", () => {
cy.mount(
<Breadcrumbs>
<BreadcrumbsItem href="#">Link1</BreadcrumbsItem>
<BreadcrumbsItem>Location</BreadcrumbsItem>
</Breadcrumbs>
);

cy.get("[ui5-breadcrumbs]")
.shadow()
.find(".ui5-breadcrumbs-root")
.should("have.attr", "aria-label", "Breadcrumb Trail");
});

it("reflects accessibleName on the nav element's aria-label", () => {
cy.mount(
<Breadcrumbs accessibleName="My Custom Breadcrumbs">
<BreadcrumbsItem href="#">Link1</BreadcrumbsItem>
<BreadcrumbsItem>Location</BreadcrumbsItem>
</Breadcrumbs>
);

cy.get("[ui5-breadcrumbs]")
.shadow()
.find(".ui5-breadcrumbs-root")
.should("have.attr", "aria-label", "My Custom Breadcrumbs");
});
});
11 changes: 10 additions & 1 deletion packages/main/src/Breadcrumbs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,15 @@ class Breadcrumbs extends UI5Element implements IToolbarItemContent {
@property()
separators: `${BreadcrumbsSeparator}` = "Slash";

/**
* Defines the accessible name of the component.
* @default undefined
* @public
* @since 2.22.0
*/
@property()
accessibleName?: string;

/**
* Holds the number of items in the overflow.
* @default 0
Expand Down Expand Up @@ -662,7 +671,7 @@ class Breadcrumbs extends UI5Element implements IToolbarItemContent {
}

get _accessibleNameText() {
return Breadcrumbs.i18nBundle.getText(BREADCRUMBS_ARIA_LABEL);
return this.accessibleName || Breadcrumbs.i18nBundle.getText(BREADCRUMBS_ARIA_LABEL);
}

get _dropdownArrowAccessibleNameText() {
Expand Down
Loading