feat(ui5-search): max-height for suggestions dropdown#13603
Open
aleksandar-terziev wants to merge 1 commit into
Open
feat(ui5-search): max-height for suggestions dropdown#13603aleksandar-terziev wants to merge 1 commit into
aleksandar-terziev wants to merge 1 commit into
Conversation
Collaborator
|
🚀 Deployed on https://pr-13603--ui5-webcomponents-preview.netlify.app |
ilhan007
reviewed
Jun 4, 2026
| * @public | ||
| * @since 2.9.0 | ||
| * @experimental | ||
| * @csspart search-popover - Used to style the suggestions popover content |
Contributor
There was a problem hiding this comment.
I would strip search from the name as the component is Search, so maybe popover, dropdown, or suggestion-popover
ilhan007
previously approved these changes
Jun 4, 2026
ilhan007
left a comment
ilhan007
left a comment
Contributor
There was a problem hiding this comment.
minor comment regarding the part name, otherwise seems fine + 1
aleksandar-terziev
force-pushed
the
suggestion-dropdown-max-height
branch
from
8786db2 to
8250ae0
Compare
aleksandar-terziev
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
aleksandar-terziev
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
TeodorTaushanov
requested changes
Jun 9, 2026
TeodorTaushanov
left a comment
TeodorTaushanov
left a comment
Member
There was a problem hiding this comment.
max-height should work on component level:
<ui5-popover
style="max-height: 200px">
</ui5-popover>
However, it isn’t working at the moment. I’ve opened issue #13663 for this. Once it’s fixed, the root part won’t be necessary.
JIRA: BGSOFUIRILA-4504 - expose `popover` to allow dynamic max-height for the search popover - default max-height is 39rem
aleksandar-terziev
force-pushed
the
suggestion-dropdown-max-height
branch
from
f08e7b6 to
af3debc
Compare
aleksandar-terziev
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
Member
|
+1 for the ui5-popover part |
Member
|
#13668 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: BGSOFUIRILA-4504
expose
popoverto allow dynamic max-height for the search popoverdefault max-height is 39rem