test(ui5-datetime-picker): unskip unstable test#13682
Open
hinzzx wants to merge 1 commit into
Open
Conversation
|
🚀 Deployed on https://pr-13682--ui5-webcomponents-preview.netlify.app |
didip1000
approved these changes
Jun 15, 2026
didip1000
left a comment
didip1000
left a comment
Contributor
There was a problem hiding this comment.
Other than the small formatting issue the change looks promising
| this._activateClock(clockIndex); | ||
| } else { | ||
| currentClockComponent?._firstNumberElement?.addEventListener("animationend", () => this._activateClock(clockIndex), { once: true }); | ||
| currentClockComponent?._firstNumberElement?.addEventListener("animationend", () => { this._activateClock(clockIndex); }, { once: true }); |
Contributor
There was a problem hiding this comment.
i dont think the ; is needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not for merge yet.
The following PR's goal is to observe the flaky test in production as it has passed successfully 235 times locally.