Skip to content

fix 171 Wrong tooltip for toggle settings #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
junaidferoz wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix 171 Wrong tooltip for toggle settings #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ files/*.zip

# database dumps
db_dumps/

# backend
logs/
# backen

@dennis-zyska dennis-zyska Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling mistake

backend/sessions
backend/node_modules
backend/logs
Expand Down
3 changes: 3 additions & 0 deletions backend/db/config/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
*
* @author Nils Dycke
*/
const path = require("path");
require("dotenv").config({path: path.resolve(__dirname, "../../../.env")});

Copilot AI Apr 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hard-codes loading ../../../.env. The repo supports environment-specific files via ENV (see Makefile includes .env.${ENV}), but this config will always read only .env when env vars aren’t already set (e.g., running backend/db scripts directly). Consider loading .env.${process.env.ENV} when ENV is set (falling back to .env), or relying on the parent process to provide env vars to avoid surprising configuration mismatches.

Suggested change
require("dotenv").config({path: path.resolve(__dirname, "../../../.env")});
const envFileName = process.env.ENV ? `.env.${process.env.ENV}` : ".env";
require("dotenv").config({path: path.resolve(__dirname, "../../../", envFileName)});

Copilot uses AI. Check for mistakes.

@dennis-zyska dennis-zyska Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you do that here, is it needed?


module.exports = {
development: {
username: 'postgres',
Expand Down
6 changes: 5 additions & 1 deletion frontend/src/components/dashboard/settings/SettingItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
:checked="setting.value"

Copilot AI Apr 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkbox uses v-model="setting.value" and also binds :checked="setting.value". In Vue, v-model already controls the checked state for checkboxes, so the extra :checked binding is redundant and can lead to confusing/duplicated sources of truth. Consider removing the :checked binding and rely on v-model alone.

Suggested change
:checked="setting.value"

Copilot uses AI. Check for mistakes.
class="form-check-input"
role="switch"
title="Activate/Deactivate NLP support"
:title="getBooleanToggleTooltip(setting)"
type="checkbox"
>
</div>
Expand Down Expand Up @@ -137,6 +137,10 @@ export default {
}
},
methods: {
getBooleanToggleTooltip(setting){

@dennis-zyska dennis-zyska Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name of the function seems misleading

const label = (setting.description && setting.description.trim()) || setting.key;
return `${label}`;
Comment on lines +140 to +142

Copilot AI Apr 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getBooleanToggleTooltip currently just returns the computed label via a template literal. Consider returning label directly (no interpolation needed) and matching the spacing/style used by the other methods (space before {) to keep formatting consistent in this file.

Suggested change
getBooleanToggleTooltip(setting){
const label = (setting.description && setting.description.trim()) || setting.key;
return `${label}`;
getBooleanToggleTooltip(setting) {
const label = (setting.description && setting.description.trim()) || setting.key;
return label;

Copilot uses AI. Check for mistakes.
},
toggleCollapse() {
this.collapsed = !this.collapsed;
},
Expand Down
Loading