fix : enable first-time setup wizard on main production build - #314
Open
mohammadsherif0 wants to merge 2 commits into
Open
fix : enable first-time setup wizard on main production build#314mohammadsherif0 wants to merge 2 commits into
mohammadsherif0 wants to merge 2 commits into
Conversation
dennis-zyska
requested changes
Jul 31, 2026
| RUN make ENV=$ENV build-frontend | ||
|
|
||
| CMD ["sh", "-c", "make ENV=$ENV NODE_ENV=production init dev-backend"] | ||
| CMD ["sh", "-c", "make ENV=$ENV NODE_ENV=production init dev-backend-wizard"] |
Collaborator
There was a problem hiding this comment.
Just to make sure, it is only used in the first run until settings are set?
Collaborator
Author
There was a problem hiding this comment.
Yes the wizard only runs while app.setup.wizardCompleted is unset/false. After setup completes, that setting is stored in the DB and the app routes to login/normal use instead of /wizard.
I also tested it locally and it works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't skip wizard for make ENV=main build