Feat 318 bulk creation error - #319
Open
karimouf wants to merge 3 commits into
Open
Conversation
bingobongomann
self-requested a review
August 3, 2026 09:03
bingobongomann
approved these changes
Aug 4, 2026
bingobongomann
self-requested a review
August 6, 2026 10:28
bingobongomann
approved these changes
Aug 10, 2026
bingobongomann
left a comment
Collaborator
There was a problem hiding this comment.
Tested it on the full eiwa data assign 7500 sessions in around 2500 studies. It took almost 10min to finish but ran without any issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes two frontend issues:
Assignment with ID X not foundand left the modal open (even though the assignment was created successfully server-side), because the CSV-export step referenceddocumentsTable,submissionsTable, andreviewer— none of which exist onAssignmentModal.vueImprovements
Bug fixes
documentsTable,submissionsTable,reviewer), which broke the lookup and preventedonSuccess()(modal close + success toast) from running. Now uses the component's actual state (assignmentModalValue,selectedReviewer)assignmentType === 'document' ? ... : ...branch used to pick which table to search — the list being searched (assignmentModalValue) already only contains items of the currently active assignment type, making the branch redundant. It was also wrong for thestudy_sessiontype, which incorrectly fell into the submission branchsnippet of old create bulk assignment function: