Feat 308 email template admin access - #334
Open
mohammadsherif0 wants to merge 4 commits into
Open
Conversation
mohammadsherif0
requested review from
bingobongomann,
dennis-zyska and
karimouf
August 9, 2026 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #308: after admin is removed, a user who still owns email templates (types 1/2/3/6/7) could view/edit/save them without a hard refresh. Email template actions now re-check admin, and the rights cache refreshes when
rolesUpdatedAtchanges.Please review #333 first: it already restricts public list/view to importable types (4/5) for non-admins; this PR continues that policy for owned email templates and for mid-session demotion.
Improvements
getContent/editContent/closeTemplate/updateFromSourcedeny non-admins (owners included).expandBroadcastFilteronly tracks sources for importable copies (types 4/5), so non-admins are not subscribed to email sources.getUserRolesByIdignores soft-deleted role rows.User.cache.clear()after role updates sofindByPksees the newrolesUpdatedAt.isAdmin/hasAccesscompare DBrolesUpdatedAt(ms) to the cached stamp and reload when it changes.!== undefined), so a deny is not looked up again every time.Idea / open question
Can all Socket subclasses on one connection share a single rights cache? Right now each keeps its own
userInfo.