Fix/audit corrections - #117
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary 📝
A few steps could give wrong or degraded results on some models; this fixes them.
Details
Modeldefaultsdtype="auto": float32 for small models and bfloat16 for large ones, so small-model logits stay correct.Intervenestep now gives an error when a direction targets no hooked site, instead of returning the clean generation as the intervened one.LogitLensno longer stores the full vocab probabilities by default; passstore_full_probs=Trueto keep them.LogitAttributionnow handles Gemma-family RMSNorm, so its completeness holds there.Checks