[Feat] #257: 커서페이징 도입#258
Open
oneeee822 wants to merge 4 commits into
Open
Conversation
3 tasks
yooniicode
approved these changes
Apr 1, 2026
yooniicode
left a comment
yooniicode
left a comment
Collaborator
There was a problem hiding this comment.
전반적으로 잘 구현해두신 것 같아요! 몇 가지 피드백 적었으니 확인 부탁드립니다. :)
| ); | ||
|
|
||
| Slice<Bubble> findByMember_MemberIdAndIsTrashedFalseOrderByBubbleIdDesc(Long memberId, Pageable pageable); | ||
| Slice<Bubble> findByMember_MemberIdAndIsTrashedFalseAndBubbleIdLessThanOrderByBubbleIdDesc(Long memberId, Long cusorId, Pageable pageable); |
| nextCursorId = bubbleSlice.getContent().get(bubbles.size()-1).getBubbleId(); | ||
| } | ||
|
|
||
| CursorPageInfo pageInfo = new CursorPageInfo(cursorId, bubbleSlice.hasNext(), pageable.getPageSize()); |
Collaborator
There was a problem hiding this comment.
위에서 계산한 nextCursorId가 들어가야 할 것 같습니다.
CursorPageInfo pageInfo = new CursorPageInfo(nextCursorId, bubbleSlice.hasNext(), pageable.getPageSize());
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#⃣ 연관된 이슈
📝 작업 내용
📸 스크린샷 (선택)
💬 리뷰 요구사항(선택)