Skip to content

Feat/u32 vectorized#29

Open
olwmc wants to merge 11 commits intoURI-ABD:masterfrom
olwmc:feat/u32-vectorized
Open

Feat/u32 vectorized#29
olwmc wants to merge 11 commits intoURI-ABD:masterfrom
olwmc:feat/u32-vectorized

Conversation

@olwmc
Copy link

@olwmc olwmc commented Nov 5, 2023

This should be ready for review. The main additions from this, either than the U32xN types are the impl_distances_uint and impl_naive_int.

TODO

  • Bump version
  • Signed support (once this is approved)

@ndaniels
Copy link
Collaborator

Why is your TODO list itself a work in progress? TODO: finish writing TODO list? ;-)

(also, 'version bump' should be in the TODO list)

@olwmc
Copy link
Author

olwmc commented Nov 12, 2023

Why is your TODO list itself a work in progress? TODO: finish writing TODO list? ;-)

Done 😎

(also, 'version bump' should be in the TODO list)

These are my “pre turning this into a real PR” TODO’s. I typically delete them after converting this from a draft. I do this half to remember what I’m doing and half to give others an idea of how this PR is progressing. That will be on the “actual for real this time” TODO

@olwmc
Copy link
Author

olwmc commented Nov 13, 2023

Investigating failure on c1cd79c on the randomized testing. This might be because I fixed my local symagen before actual repo had its own change up, and I pushed "broken" code (w.r.t. the symagen github) or if there is actually an issue... 💀

Edit: Reran the tests 300 times for i in {1..300}; do cargo test simd::test::u32_tests::verify_random; done with a different seed each time and can't get it to break 🫡.

@olwmc olwmc marked this pull request as ready for review November 14, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants