Added Kulsinski distance and set distance tests#35
Open
brianmaterne wants to merge 5 commits intoURI-ABD:masterfrom
Open
Added Kulsinski distance and set distance tests#35brianmaterne wants to merge 5 commits intoURI-ABD:masterfrom
brianmaterne wants to merge 5 commits intoURI-ABD:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I coded in Kulsinksi distance in the same file as Jaccard distance using the same format, relatively self explanatory.
I also added a test_sets.rs file to the tests folder, which contains tests for the Jaccard and Kulsinski distances and can easily be added to. I use random exhaustive testing, creating two 1000 length sets with each number randomly swapped to be on or off. I then check if each function gives the intended result finding distance between the two.
I then have some checks of edge cases, with one or both sets being empty or both sets being the same.
Both of these testing methods are easily addable to once a new set distance function is added.
I also added and checked off Kulsinski distance in the ReadMe.