Update various packages.#1676
Open
MikeNeilson wants to merge 2 commits intodevelopfrom
Open
Conversation
Contributor
Author
|
UI still works, also corrected the behavior for the swagger-docs link, previous fix did not quite do the trick. |
4e7122b to
6a6657e
Compare
krowvin
requested changes
Apr 14, 2026
Collaborator
krowvin
left a comment
There was a problem hiding this comment.
Wondering about the version downgrade on the generator before you merge
| }, | ||
| "devDependencies": { | ||
| "@openapitools/openapi-generator-cli": "^2.15.3", | ||
| "@openapitools/openapi-generator-cli": "^0.0.6", |
Collaborator
There was a problem hiding this comment.
Why are we downgrading the generator? I think we might have picked the wrong version because this could introduce some unforeseen security issues going this far back?
I assumed it might be because of the old javalin/java version but wanted to make sure.
Contributor
Author
There was a problem hiding this comment.
Huh, thanks, didn't catch that. I'm not sure what happened there, I ran npm audit fix --force might have had something to do with the force, but definitely going backwards there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Am manually testing the CDA GUI now, wanted to get the rest of the build started.
Manually handles several dependabot/security reports that weren't getting updated by the automation.