Addition of sslmode to pgx and pg_dialect db types#3
Open
charles-p-howe wants to merge 2 commits intoUSACE:mainfrom
Open
Addition of sslmode to pgx and pg_dialect db types#3charles-p-howe wants to merge 2 commits intoUSACE:mainfrom
charles-p-howe wants to merge 2 commits intoUSACE:mainfrom
Conversation
…ill default to disable, if an invalid sslmode is entered, it will be set to disable, otherwise if a valid sslmode is set, it will be used for pgx connections. user of the module will be responsible for any cert installation or needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To keep developer changes to a minimum, this should not require any changes to continue using.
If no changes are made goquery will set sslmode=disable as the default
If a dev wants to explicitly set the sslmode, set it either via the RdbmsConfig type declaration:
dbconfig := gq.RdbmsConfig{ Dbuser: Dbuser, Dbpass: Dbpass, Dbport: Dbport, Dbhost: Dbhost, Dbname: Dbname, DbSSLMode: "prefer", DbDriver: "pgx", DbStore: "pgx", }Or via the RdbmsConfigFromEnv() by using the DBSSLMODE env variable.
Currently accepted sslmodes:
If a sslmode is sent not in the above list, it will log a warning and set the sslmode to disable.