Open
Conversation
|
Please set a versioning label of either |
Contributor
Author
|
Will remove id for props spread and test to make sure multiple still work |
Contributor
Author
|
id removed, ready for merge/review |
willbreitkreutz
requested changes
Jul 14, 2025
Contributor
willbreitkreutz
left a comment
There was a problem hiding this comment.
Let's just pass all props down to the Accordion body rather than just the id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the
Accordioncomponent to enhance its functionality and documentation. The most important changes include updating the import statements, adding new props to theAccordioncomponent, and updating the documentation to reflect these changes.Enhancements to
Accordioncomponent:lib/components/display/accordion.jsx: Updated the import statements to includeDisclosureButtonandDisclosurePanelfrom@headlessui/react.lib/components/display/accordion.jsx: Added new propsisOpen,onToggle, andidto theAccordioncomponent to allow for more control over its state and behavior.Documentation updates:
src/app-pages/documentation/display/accordion.jsx: Updated the documentation to include descriptions for the new propsclassName,isOpen,onToggle,children, andid.